search

besser82 / libxcrypt

Extended crypt library for descrypt, md5crypt, bcrypt, and others
GNU Lesser General Public License v2.1
189 stars 52 forks source link

Build failure #162

Closed haampie closed 1 year ago

haampie commented 1 year ago

libxcrypt: 4.4.30 gcc: 11.2.0

lib/alg-yescrypt-opt.c:517:40: error: conversion to 'long long unsigned int' from 'long long int' may change the sign of the result [-Werror=sign-conversion]

Edit: I noticed #161, just not released yet.

besser82 commented 1 year ago

@haampie, does applying the patch from #161, or https://github.com/besser82/libxcrypt/commit/17cf4ce8af5a2a1af4c0f52260019cbae01835b8, fix your issue?

haampie commented 1 year ago

Yes, fixes it. Maybe keep this issue open until the next release? Cause I looked first in open issues where I found nothing. Also happy if you close it.

besser82 commented 1 year ago

Fixed in release v4.4.31.