search

besser82 / libxcrypt

Extended crypt library for descrypt, md5crypt, bcrypt, and others
GNU Lesser General Public License v2.1
189 stars 52 forks source link

Remove smartmatch usage from gen-crypt-h #172

Closed akhuettel closed 1 year ago

akhuettel commented 1 year ago

This is also needed for building with Perl 5.38... another smartmatch usage that now triggers a deprecation warning.

BTW, it's really a bad idea to treat these warnings all as errors. Otherwise we'd get a warning now, but not a failure... more time to fix stuff...

thesamesam commented 1 year ago

@besser82 Could you take a look? Perl 5.38 is now out. Cheers!

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (213d2b7) 89.87% compared to head (95d6e03) 89.87%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #172 +/- ## ======================================== Coverage 89.87% 89.87% ======================================== Files 32 32 Lines 3626 3626 Branches 690 690 ======================================== Hits 3259 3259 Misses 227 227 Partials 140 140 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

besser82 commented 1 year ago

LGTM! Thank you!