search

besser82 / libxcrypt

Extended crypt library for descrypt, md5crypt, bcrypt, and others
GNU Lesser General Public License v2.1
178 stars 49 forks source link

Man page edits #185

Open solardiz opened 3 months ago

solardiz commented 3 months ago

This is motivated by the criticism in https://www.openwall.com/lists/yescrypt/2024/03/21/1 that our wording "CPU time cost" was misleading, given that with memory-hard methods it also affects memory usage. That's addressed in the first commit here. The second commit is based on my proof-reading of the entire crypt.5.

Not yet changed here, but something we might also want to change, is renaming of the count parameter to cost. Perhaps not only in man pages, but also in code.

Edit: This also fixes #29

solardiz commented 3 months ago

This also fixes #29

solardiz commented 3 months ago

@vt-alt You might want to review my edits of the gost-yescrypt description here.

vt-alt commented 3 months ago

@solardiz LGTM

solardiz commented 1 month ago

@besser82 @zackw Can you please merge this PR? I see no reason not to. You may say that more changes are desired, but that's no reason not to merge the changes so far. Thanks!

zackw commented 1 month ago

I have not had time to look at these changes at all. Please be patient.