besser82 / libxcrypt

Extended crypt library for descrypt, md5crypt, bcrypt, and others
GNU Lesser General Public License v2.1
189 stars 52 forks source link

Use macros to detect endianness if configure cannot tell. #44

Closed besser82 closed 5 years ago

besser82 commented 5 years ago

Some systems provide a way to build a single binary that runs on any of their architectures. Thus detecting the system's endianness statically during configure stage is not sufficient.

Fixes #42.

codecov-io commented 5 years ago

Codecov Report

Merging #44 into develop will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #44   +/-   ##
========================================
  Coverage    90.04%   90.04%           
========================================
  Files           32       32           
  Lines         3204     3204           
========================================
  Hits          2885     2885           
  Misses         319      319
Impacted Files Coverage Δ
crypt-bcrypt.c 98.11% <ø> (ø) :arrow_up:
alg-sha1.c 99.23% <ø> (ø) :arrow_up:
alg-sha512.c 99% <ø> (ø) :arrow_up:
crypt-port.h 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 453ac0b...2541be3. Read the comment docs.

besser82 commented 5 years ago

Now the macOS build should be fine except for the linker invocation, but that will be fixed in a different PR.

besser82 commented 5 years ago

@zackw Will merge when TravisCI goes green.