search

besser82 / libxcrypt

Extended crypt library for descrypt, md5crypt, bcrypt, and others
GNU Lesser General Public License v2.1
189 stars 52 forks source link

Use prebuilt object files from libcrypt for linking the tests. #70

Closed besser82 closed 5 years ago

besser82 commented 5 years ago

Partially cherry-picked from #67.

codecov[bot] commented 5 years ago

Codecov Report

Merging #70 into develop will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #70   +/-   ##
========================================
  Coverage    91.96%   91.96%           
========================================
  Files           32       32           
  Lines         2988     2988           
========================================
  Hits          2748     2748           
  Misses         240      240

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eae4a63...a541452. Read the comment docs.

zackw commented 5 years ago

It occurs to me that this is arcane enough to deserve a comment in the Makefile. Right above the definition of COMMON_TEST_OBJECTS:

# Refer to object files that are linked into libxcrypt with the
# qualified name, libcrypt_la-foobar.lo, to prevent them from
# being compiled a second time.
besser82 commented 5 years ago

@zackw Fixed in rebased commit.