best-cost / best-cost_WPs

This repository aim to collect the confidential (not public) work of the EU project BEST-COST in the framework of the workpackages (WPs).
1 stars 0 forks source link

Argument input `bhd_upper` not considered in iteration #334

Closed luytax closed 1 week ago

luytax commented 2 weeks ago

When doing an iteration with attribute_health(), e.g. in the chunk with the result variable bestcost_pm_copd_geo, the input to bhd_upper is not used in the calculations. It doesn't matter if it's 0 or any other number.

Seemingly, the value of bhd_lower is used for both bhd_upper and bhd_lower.

With bhd_upper = 0 image

The value in the bhd column in bestcost_pm_copd_geo[["detailed"]][["raw"]] for the rows where bhd_ci is lower (second row in screenshot below) resp. upper (3rd row) is the same. This happens no matter what you input to the argument bhd_upper. image

ungatoverde commented 1 week ago

Bug fixed here: #337