Closed YDX-2147483647 closed 1 year ago
I am working on it.
Config | Description | Default |
---|---|---|
ascii_description |
If True , all non-ASCII characters in the project description will be removed. Useful for
filtering out distractive emoji, but hurtful in non-English cases. (Note: GitHub emoji commands (e.g.
:smile: ) are always removed.) |
True |
Describe the bug:
If a project's description is not English,
best-of
will think it's all of special characters and remove anything.(see
remove_special_chars
called inprocess_description
)https://github.com/best-of-lists/best-of-generator/blob/a0c6d8a37b57e5cfe8a6d684ac312605d94bbedc/src/best_of/utils.py#L32-L56
Expected behaviour:
remove_special_chars
. (I can try to make a PR if you'd like)Steps to reproduce the issue:
Original description: (from BIThesis)
Result: (in best-of-bits)
Technical details:
Possible Fix:
Additional context: