best-of-lists / best-of-generator

🏆 Generates a ranked list of awesome libraries and tools.
https://best-of.org
GNU General Public License v3.0
79 stars 14 forks source link

Allow non-ASCII description #62

Closed YDX-2147483647 closed 1 year ago

YDX-2147483647 commented 1 year ago

What kind of change does this PR introduce?

Description:

Add config ascii_description to resolves #61.

Config Description Default
ascii_description If True, all non-ASCII characters in the project description will be removed. Useful for filtering out distractive emoji, but hurtful in non-English cases. (Note: GitHub emoji commands (e.g. :smile:) are always removed.) True

Technically:

Checklist:

YDX-2147483647 commented 1 year ago

Hi, may I ask a question?

How can I use ascii_description in my GitHub Actions? Or should I make a PR to best-of-update-action? (I noticed that all PRs there were made by robots…)

lukasmasuch commented 1 year ago

@YDX-2147483647 I need to release a new version for this and then it will become accessible in the action. I will try to attempt that within the next few days.

YDX-2147483647 commented 1 year ago

I see, thank you!

YDX-2147483647 commented 1 year ago

So, did you encounter difficulties? Anything I can help?

YDX-2147483647 commented 1 year ago

Just FYI, I've worked out some tricks to test it, and everything works as expected!

Details:

  1. I forked the update-action repo, and let pip install from GitHub directly.

  2. Edit .github/workflows/update-best-of-list.yml in my own repo:

    - name: update-best-of-list
     # uses: best-of-lists/best-of-update-action@v0.8.5
     uses: YDX-2147483647/best-of-update-action@ascii-description
  3. Go to Actions in my own repo, run the workflow manually.