best-practice-and-impact / ons-spark

MIT License
9 stars 5 forks source link

Feat date-functions article #132

Closed AntonZogk closed 9 months ago

AntonZogk commented 11 months ago

Merge request template: please remove the appropriate parts of this template.

Pre-merge request checklist (to be completed by the one making the request):

Details of this request (such as): Added guidance on dates in pyspark and sparklyr

Requirements for review (such as):

AntonZogk commented 10 months ago

@NathanKelly-ONS i didn't use the converter for this, i created the markdown from scratch

NathanKelly-ONS commented 10 months ago

@NathanKelly-ONS i didn't use the converter for this, i created the markdown from scratch

@AntonZogk I appreciate that it probably took a fair amount of time (and will take even longer to make these changes) but just creating a markdown and uploading it from scratch really isn't the best practice. There's no way to verify that the code actually runs and produces the output that is listed in the output (especially the R code - I know the notebook that this was based on contains the PySpark code) and no trail showing how the page was created. Plus, I imagine there are some users (and also people working on adding additional features to the page) who would want to play around with the code in the notebook which they can't do if we just have the markdown page.

Hope that makes sense - not a priority to work on this if you're busy with other things but when you get a chance it's definitely best practice to create the notebook too.