besteon / Ironmon-Tracker

A Lua script for the Bizhawk/mGBA emulator compatible with Pokemon Fire Red, Leaf Green, Ruby, Sapphire, and Emerald that tracks relevant data for the IronMon challenge.
MIT License
123 stars 44 forks source link

Update displayed power based on STAB/effectiveness. Update displayed acc based on acc/evasion #350

Closed Aeiiry closed 1 year ago

Aeiiry commented 1 year ago

Made this mostly for myself, pretty simple stuff right now. Opening a pull request in case this may be something other people would like

https://github.com/Aeiiry/Ironmon-Tracker/blob/acc-dmg-autocalc/README.md

UTDZac commented 1 year ago

Hey Aeiiry, thanks for your interested in adding to the Ironmon Tracker project. This is a pretty cool feature update to automatically do calculations for you.

However, this is not something we're looking to officially add or make available on the Tracker. The primary reason is because of the amount of work this does for a person with regards to the Tracker playing the game for you. This automatically trivializes the choices made, removing that element of play from the game itself. Ultimately this is a two-part change, and I have some notes on each.

Automatically calculating the power for move effectiveness and STAB

This is a simple change but one we've purposefully chosen not to include. The Tracker already informs the user if a move meets either of these conditions and helps inform them that they can make the choice to use these "better" moves.

In short, I think the Tracker already guiding you on which moves are super-effective or not effective, as well as which benefit from STAB, is altogether sufficient enough information for players to make better, meaningful decisions during battle without the Tracker taking away that element of gameplay or decision.

Automatically calculating the new accuracy/evasion values

While it is true that this is something that the Ironmon Tracker can do for the player, I believe this reaches into the space of offering too much advice and guidance that a player wouldn't normally have (or bother to even lookup). It might be easiest to show as a comparison of another type of information: move effectiveness based on Pokemon type(s).

In short, providing exact calculations for accuracy/evasion isn't something that most players do, or need, while playing. The Tracker doesn't need to go over the top and provide this information on hand, as it's not critical to play the game. While yes it is convenient, I believe it's too convenient, as most people don't bother wanting to lookup this information to make decisions.

Aeiiry commented 1 year ago

Thanks a bunch for the replies :). Perfectly understandable reasoning for not wanting this added to the tracker, honestly I think I got a bit too focused on displaying information that a player could know instead of what a player would reasonably know. Thank you for the comments on the code fellshadow. I'll go ahead and close this pull request