edit log parse pattern strings to be more flexible

[Aeiiry]

This was primarily for myself, as I was having issues with the view "view log" fucntion when using the ironmon randomizer https://github.com/something-smart/ironmon-randomizer and/or settings trainers to all be doubles battles for whatever reason. Shouldn't mess up existing logs, but I haven't tested it extensively outside of old logs from the regular randomizer I had lying around.

[UTDZac]

For each pattern you've changed, can you speak to why these changes are necessary and perhaps share examples? When I originally created these patterns, I thoroughly tested them for all the games people typically play for Ironmon.

[UTDZac]

If you have time to test and verify this on a FRLG log and an Emerald log, each from Randomizer 4.6.0 and Randomizer 4.4.0, and verify this works for all four cases, that would be great. I recommend checking through a variety of pokemon with weird names, such as Mr. Mime, Farfetch'd, Nidoran(Male), and checking through the elite four teams.

I have limited time myself and won't be able to verify these changes thoroughly.

[Aeiiry]

I've started doing testing of the games and randomizers above, will update this PR when I'm done.

[Aeiiry]

All changes including my most recent commit tested without encountering any issues. Randomizers tested: PokeRandoZX version 4.6.0 and 4.4.0 [PokeRandoZX ironmon edit version 1.5.0(https://github.com/something-smart/ironmon-randomizer)

Roms tested: Pokemon Emerald Pokemon Firered

Methodology: For each combination of rom and randomizer, and also for "lower case pokemon names" enabled and disabled:

• Set up the quickload settings in the tracker to use the rom and randomizer being tested, set the settings file to be a kaizo ironmon settings file compatible with pokerandozx v4.4
• Randomize the game with the tracker's quickload
• Play through the opening sequence until starter pokemon can be made to faint
• Click "view log"
• Ensure bulbasaur and chimeco show info from the log. If any pokemon wasn't parsed correctly in the log then all pokemon after it will not be parsed correctly either
• Check split evolutions for 2,3 and >3 evolutions. I usually checked wurmple, tyrogue, and eevee
• Check elite 4 teams populated correctly and check the individual pokemon on their teams populated correctly.

Additionally I tested enabling as many other randomizer settings as I could and doing the same tests above (randomized types, moves, etc)

No issues encountered

[UTDZac]

Thank you for doing some tests. I noticed your change to the PokemonName pattern causes issues with some log files. This change excludes some possibilities. The most important difference I notice is that your pattern excludes the possibility of a ? character, which does show up in some logs for some randomizers and some games. There may exist other differences.

I've attached an example log: RSE Kaizo lower names AutoRandomized.gba.log

PokemonName Pattern change:

• Old: PokemonName = "([%u%d%.]* ?[%u%d%.'%-♀♂%?]+).-",
• New: PokemonName = "(%u%a+[%a%d%.’'%-♀♂%s]*)",

Ultimately, your change needs to still include all possible matches the previous pattern included, while also including the adjustments you want to make. The challenge is being careful about assumptions of what the log file looks like, as there exist many other variations of log files that we've stumbled upon that cause issues. Sorry this isn't better documented.

At some point I'll have more time to dig into this more and maybe help find a good solution, but currently out of time to dig into this thoroughly. I've personally not great at patterns, so it often takes me a long time to test all the cases.