besteon / Ironmon-Tracker

A Lua script for the Bizhawk/mGBA emulator compatible with Pokemon Fire Red, Leaf Green, Ruby, Sapphire, and Emerald that tracks relevant data for the IronMon challenge.
MIT License
129 stars 45 forks source link

Log Parser: Adding support for custom Pokémon names #370

Closed UTDZac closed 1 year ago

UTDZac commented 1 year ago

For cases where the player has modified their rom to replace Pokemon names and move names with custom names. The log viewer now properly parses most of this information and displays it. There are some cases where this can fail, such as duplicate custom names (no unique identifier) or weird symbols.

There are quite a few wonky changes necessary to get the parser compatible with custom named logs, so feel free to just skim through this quickly. Mostly just wanted a second set of eyes if anything looks completely out of place here.

I tested on a custom log from a streamer where many Pokémon names and moves are renamed. I also test that it can properly load up different logs and use all info from that log instead of relying on info from the game rom itself. In the past, the abilities of pokemon and the types of pokemon were just retrieved from the rom, but this fails when wanting to view a previous log from a different rom (future feature)