besteon / Ironmon-Tracker

A Lua script for the Bizhawk/mGBA emulator compatible with Pokemon Fire Red, Leaf Green, Ruby, Sapphire, and Emerald that tracks relevant data for the IronMon challenge.
MIT License
129 stars 45 forks source link

Battle effects screen #428

Open jtigues opened 1 year ago

jtigues commented 1 year ago

There is one known and incredibly minor bug I have not been able to sort out: I cannot for the life of me get the text & buttons to appear with shadows, and it seems it should work fine enough. But functionally, everything works fine across Games and Languages. Another note: the plan is eventually to have the Last Move used by each pokemon displayed separately here. But that framework is not in place yet, so it just shows the Last Move used as recorded by the Last Damage framework Also, I don't know where this expYield removal change came from, if I need to go in and manually re-add all of those that's fine.

jtigues commented 1 year ago

Few small things I've noticed looking back over it:

jtigues commented 1 year ago

Few small things I've noticed looking back over it:

  • "stale" flag is no longer used but still has references
  • BattleEffectsScreen Button is being drawn unnecessarily, the button is invisible
  • Left Arrow pixel image has an extra column of 0s, it's actually 10 by 9.

Fixed

jtigues commented 1 year ago

expYield has been added back in, and the various concerns with the syntax/formatting have been resolved.

Also added the text strings to the non-English files, oops.