Closed mdmurphy2 closed 8 months ago
Testimony xD
It looks like this has some conflicts. I'd recommend trying to reset your branch to our current dev branch, I'm not sure why this PR is including old stuff that got changed up.
This feature is one I want to explore more before committing to adding it. This is mostly a case of wanting to understand how it can be a helpful core addition to the Tracker (as opposed to a custom extension). I struggle to see a need or want for something like this. Who is this for? Typically people play the game without speedup at all, or with speedup permanently on, especially for early game.
If this is something we want to add, we'd need to resolve the below. Feel free to hold off on resolving these until we decide if this is something we want to add or not. I merely wrote them all down as I was testing and reviewing this feature.
A few notes about this feature:
emulationSpeed = 100
and isFastForwarding = false
need to be set in the initialize()
function of that file. The emulators have this weird thing where it remembers any current value defined in that global on reset/quickload. So if someone quickloads while the above variables have changed, their new game uses the changed values and not your expected defaults.Closing, as this is more suited as a Tracker Extension than a core option.