besteon / Ironmon-Tracker

A Lua script for the Bizhawk/mGBA emulator compatible with Pokemon Fire Red, Leaf Green, Ruby, Sapphire, and Emerald that tracks relevant data for the IronMon challenge.
MIT License
125 stars 44 forks source link

[Bug]: Incorrect ability name in English.lua #456

Closed Piomale closed 5 months ago

Piomale commented 5 months ago

Describe the bug

In the file English.lua , there is a typo in the ability "Bubble Beam." It is written as "BubbleBeam" (without a space).

Due to this missing space, the ability can't be translated, and it's not possible to click on it to view details.``

Steps to Reproduce

What tracker version are you using?

v8.5.1

What operating system are you using?

Windows 11

What emulator(s) are you seeing the problem on?

Bizhawk 2.9

Relevant log output

No response

Additional Information

No response

Fellshadow commented 5 months ago

Bit confused on the overall issue, "BubbleBeam" without a space is how it is spelled in the english versions of the games prior to X & Y so the lack of space is the correct version here.

I just loaded up a rom myself and "BubbleBeam" shows without a space in the name and clicks fine onto the move info both on the main screen and in the log viewer.

Perhaps you can share a bit more info on your setup here, when you're talking about translations which language setting are you using and are you playing a non-english rom?

Also have you made any customizations to the rom at all, such as changing pokemon and/or move names? If you've changed the names of moves in the rom then that might be what's causing this issue here potentially

Zach0Dac commented 5 months ago

The language is french, if it helps.

Piomale commented 5 months ago

I just tested it, and you're right. In the base game, it should indeed be "BubbleBeam."

It seems that the error originates from the game generation by NatDexExtension, which renames the ability's name.