search

besteon / Ironmon-Tracker

A Lua script for the Bizhawk/mGBA emulator compatible with Pokemon Fire Red, Leaf Green, Ruby, Sapphire, and Emerald that tracks relevant data for the IronMon challenge.
MIT License
128 stars 46 forks source link

[Bug]: Weird behavior of the "Speed" text in setup carousel tab #459

Closed Zach0Dac closed 7 months ago

Zach0Dac commented 7 months ago

Describe the bug

I just noticed that it didn't translate the word "Speed" on the carousel tab of the setup screen. I thought I forgot to translate it, but all I found is LabelSpeedSetting = "Vitesse". Then I looked for other text in the code equal to "Speed", but the only other instance of "Speed" (outside of the word being part of bigger description like moves) was the SortSPE = "Speed" in LogSearchScreen and changing it didn't fix it. Then I tried changing LabelSpeedSetting in the English.lua, but it changed nothing neither for french or english language. Edit: Just noticed that the tab's name aren't translated either even if they should be, and the exact same issue seems to applies. Changing the English.lua still won't affect the tab's name. Other Edit: I am testing other tab's name and I think they all (or most of them) have the same issue. I tested the "tools" and "options" of the extraScreen, same issue. Another Edit: Same thing for LabelInfoToShow Capture d’écran 2024-04-18 105214 Capture d’écran 2024-04-18 110436

Steps to Reproduce

  1. Go to the carousel tab in setup
  2. Notice the word "Speed"
  3. Go to French.lua in the setupScreen section
  4. Notice the = "Vitesse",
  5. Try changing language, changing the string for the labal or changing other instance of the string "Speed", probably nothing will change

What tracker version are you using?

v8.5.2

What operating system are you using?

Windows 11

What emulator(s) are you seeing the problem on?

Bizhawk 2.8

Relevant log output

No response

Additional Information

No response

Zach0Dac commented 7 months ago

Since it affects many texts, I am trying what they all have in common that other texts don't. So far my only idea is they all start with tab or label? Most (if not all) of tab's name are affected (they are also highlighted when selected), "Speed" is LabelSpeedSetting and "Info to show" is LabelInfoToShow. I have no idea if the tracker treats differently those tabs and labels, I am also not sure if ALL variables starting with tab or label are affected (I know PokemonIconSetLabel and LabelTimer are not affected) but I assume it does.

UTDZac commented 7 months ago

The original texts you found were correct. This was just a small bug with how the Tracker starts up and creates this screens initially. Some of the texts get locked in and never change, until you close and reopen the Tracker completely.

Fixed in https://github.com/besteon/Ironmon-Tracker/commit/acb9842a3af6a04003324572960a8a3a71886de7