search

besteon / Ironmon-Tracker

A Lua script for the Bizhawk/mGBA emulator compatible with Pokemon Fire Red, Leaf Green, Ruby, Sapphire, and Emerald that tracks relevant data for the IronMon challenge.
MIT License
129 stars 45 forks source link

fix map layout id of underwater maps #489

Closed CyanSMP64 closed 1 week ago

CyanSMP64 commented 1 week ago

fixes a mistake on my part from #439 back when i wrote it, i falsely assumed the route data entry numbers were map ids instead of layout ids

UTDZac commented 1 week ago

I'm not sure how to understand what the issue is here. Working with Emerald is difficult for me, as I do not play it enough to know what is or isn't correct.

From my understanding, we had the correct route data already.

Can you share some information to explain why its incorrect? Help me understand why this change is required?

CyanSMP64 commented 1 week ago

at the time i wrote #439, i wasn't made aware of the fact that each map in the gen 3 games uses a layout id in their headers; many maps share layouts, such as generic houses, pokemon centers, and poke marts. looking at the route data now i realise that each route entry uses the layout id number (https://github.com/CyanSMP64/pokeemerald/blob/master/include/constants/layouts.h)

the underwater maps for routes 124, 126, 127, 128 follow a sequential order in the map groups (https://github.com/CyanSMP64/pokeemerald/blob/master/include/constants/map_groups.h) whereas the route 124 underwater layout has id number 274 while the others have 51-53.

this was correct until #439 was merged