search

bestguy / sveltestrap

Bootstrap 4 & 5 components for Svelte
https://sveltestrap.js.org
MIT License
1.3k stars 183 forks source link

Added Fluid Attribute to Carousel #347

Closed cstayyab closed 3 years ago

cstayyab commented 3 years ago

Allows Carousel to be created in a container-fluid wrapper instead of container hence providing the ability to make a Full Width Carousel.

Helps with https://github.com/bestguy/sveltestrap/issues/30#issuecomment-893015804

bestguy commented 3 years ago

Hi @cstayyab , thanks for the PR. I'm not sure why we need to add this class though? By default the Carousel is not in a container and already full width: https://svelte.dev/repl/43741239673a4656a9108492a9fb1002?version=3.42.1

Can you clarify what is needed here?

cstayyab commented 3 years ago

You're right @bestguy! I might have been using the old version. Apologies for not checking it before.