search

bestguy / sveltestrap

Bootstrap 4 & 5 components for Svelte
https://sveltestrap.js.org
MIT License
1.3k stars 183 forks source link

Fix click handling in Modal #442

Closed tkieft closed 2 years ago

tkieft commented 2 years ago

When using sveltestrap w/ SvelteKit, stopping propagation of the click event in modals breaks SvelteKit's handling of that click event, and so you get a full browser navigation, rather than a navigation within the single-page web app.

To repro this, build a modal with a link in the modal body.

What we actually want here is to stop propagation of the event only if it's a click on the backdrop that we handle.

bestguy commented 2 years ago

Thanks, will release patch this week. This may fix #436 as well, but will confirm