search

bestguy / sveltestrap

Bootstrap 4 & 5 components for Svelte
https://sveltestrap.js.org
MIT License
1.3k stars 183 forks source link

Feat: Support horizontal collapse #444

Closed demetrius-mp closed 2 years ago

demetrius-mp commented 2 years ago

i was trying to rebuild this sidebar using sveltestrap, but the default animations works only vertically, which feels weird for this use case. I tried adding .collapse-horizontal to the Collapse component, but it happened to be even weirder.

demetrius-mp commented 2 years ago

or maybe provide a workaround for the moment, cause i really dont see other way to "fix" this but to use bootstrap javascript, which is not desirable

bestguy commented 2 years ago

Thanks, yeah I attempted adding support and was a little confused on how this was supposed to work. Happy to take a look again and either PR or add my notes here if someone could pick it up.

bestguy commented 2 years ago

I think this is straightforward if you'd like to review @demetrius-mp : https://github.com/bestguy/sveltestrap/pull/445/files

demetrius-mp commented 2 years ago

it works just great! you can close the issue if you want.

bestguy commented 2 years ago

Released in v5.9.0, thanks for the heads up.