Open JulioHD opened 2 years ago
Any news on getting this merged? Especially that when using Collapse in a navbar that on desktop it has a fade in animation is really annoying.
Any news on getting this merged? Especially that when using Collapse in a navbar that on desktop it has a fade in animation is really annoying.
Maintainer seems to be inactive again, never heard from him on this issue. This pull request is a bit unclean anyways, I mistakenly fixed another issue in the branch for my personal project, so I get why this isn't being accepted. I would correct that, if needed.
Hi there
I came across some issues using collapse within a navbar, with this following issues should be fixed:
The collapse no longer removes and re-adds it's content to the dom, instead it uses bootstrap's "d-none" class to hide it. I do that so bootstrap's "navbar-expand-xx" class can show the collapse content again, when a certain screen size is reached. We no longer need to check for that and it won't animate for a second.
Example code:
Unfortunately I couldn't find a solution how to prevent isOpen from changing, when it's accessed directly.