search

bestguy / sveltestrap

Bootstrap 4 & 5 components for Svelte
https://sveltestrap.js.org
MIT License
1.3k stars 183 forks source link

Margin on FormGroup #458

Open gamelaster opened 2 years ago

gamelaster commented 2 years ago

https://github.com/bestguy/sveltestrap/blob/master/src/FormGroup.svelte#L14

Why does FormGroup have margin bottom by default? How to remove it? (Without overloading it with CSS)

Thanks

LuisArtDavila commented 1 year ago

I would like to know as well.

glominashvili commented 1 year ago

This is causing an issue when floating FormGroup is used in InputGroup. See the example in Svelte REPL. InputGroupText element is enlarged.

I think having 'mb-3' by default is not a good idea. Users can add it as they need, but in this case I could not find a way to remove it, even if I found one, it would be a hack not a solution.

Also grep search in the 'src' directory shows that, this is one of the few places 'mb' is used (another one is 'mb-4' 'Jumbotrone.svelte), so maybe it was left by accident.

So can we remove it? I can make a PR for this.