search

bestguy / sveltestrap

Bootstrap 4 & 5 components for Svelte
https://sveltestrap.js.org
MIT License
1.3k stars 183 forks source link

Reorder bind and on: for select (fixes #461) #468

Closed clemens-tolboom closed 2 years ago

clemens-tolboom commented 2 years ago

This should fix #461.

shaun-wild commented 2 years ago

This will fix the issue for select.

Input maps to multiple underlying components, and it still won't work for those.

I'd apply the fix at every point possible in the file (bare in mind there are sub-components referenced in Input that will need the fix applying also i.e FormCheck).

Maybe add a test too?

Oh, I forgot to mention, I've already fixed this on another fork (with tests). I never created a PR though as some of the original tests were failing, the failures seemed unrelated to my changes, however. I can create a PR and save you the work if you like?

clemens-tolboom commented 2 years ago

@shaun-wild a PR would be great ... we can then close this on.

shaun-wild commented 2 years ago

I have created the PR.

clemens-tolboom commented 2 years ago

Closing in favor of #473