bestguy / sveltestrap

Bootstrap 4 & 5 components for Svelte
https://sveltestrap.js.org
MIT License
1.3k stars 183 forks source link

fix popper issue, fix failing tests & bump dependencies #488

Closed kbsali closed 1 year ago

tommygiesbrecht commented 1 year ago

Hello! Is it possible to merge this fix? Thanks Tommy

kbsali commented 1 year ago

ping @bestguy :) Maybe it is not relevant anymore? I only see now that there has been some activity in early August, that's great news! :) Would it be possible to add contributors with merging auth?

bestguy commented 1 year ago

Thanks @kbsali @tommygiesbrecht , I really appreciate the PRs and desire to fix this for SvelteKit, but none of these fixes and forks changing to '@popperjs/core' correct the root issue, which is why the PRs to change popper imports have not been merged after so long.

I've tried the same in past as I mentioned, but I've been unwilling to break the Svelte REPL. This is not deprecated AFAIK, and I'm a heavy user with Sveltestrap. (I know Sapper is deprecated so I wont worry about that one any longer).

Upgrading to Floating UI won't fix this either, as they continue the process.env usage: https://floating-ui.com/docs/getting-started#package-entry-points , and they have not accepted PRs in past to change this. It's really frustrating but that is their choice.

Only solutions I can think of is:

I will gladly take any help or ideas that fixes this if it works on svelte.dev
I really do not want to break this!

kbsali commented 1 year ago

This PR was addressing several long standing issues. This is old already, but if I remember well I was not even using the popperjs related component, but without the change I had issue building my project...

bestguy commented 1 year ago

Okay thanks, I'll cherry pick the other changes aside from the popper change.

kbsali commented 1 year ago

too bad PRs are ignored...