Fix popperjs import for SvelteKit Patch-2

bestguy / sveltestrap

Bootstrap 4 & 5 components for Svelte

https://sveltestrap.js.org

MIT License

1.3k stars 180 forks source link

Fix popperjs import for SvelteKit Patch-2 #564

Closed laxadev closed 11 months ago

laxadev commented 11 months ago

I was still faced with this issue #463 after fetched the latest fix #356 I made a fix in two more files.

benmccann commented 11 months ago

I sent a fix here: https://github.com/bestguy/sveltestrap/pull/566

laxadev commented 11 months ago

I sent a fix here: #566

@benmccann What is the difference between this PR and yours?

benmccann commented 11 months ago

Oops! I looked at this too quickly originally. Yes, your fix is the same as mine. Sorry about that. The issue description in my PR will close some linked issues with the magic "fixes" and "closes" keywords. If you want to copy that into your PR description (it doesn't work in comments, but only by editing the description) I can go ahead and close my PR

laxadev commented 11 months ago

@benmccann No worries. Let's keep yours and I'm going to close this one. Thanks.