search

bestguy / sveltestrap

Bootstrap 4 & 5 components for Svelte
https://sveltestrap.js.org
MIT License
1.3k stars 183 forks source link

chore: upgrade to storybook 7 #565

Closed benmccann closed 11 months ago

benmccann commented 11 months ago

@bestguy @gary-mycase any chance you might be able to take a look at this one?

bestguy commented 11 months ago

Sure, I'll take a look to review/merge this weekend, thanks for your patience.

kefahi commented 11 months ago

Thanks! I tried upgrading as outlined above, but couldn't successfully run storybook. What are the specific steps I need to follow to get the docs folder regenerated with the new version?

benmccann commented 11 months ago

@kefahi can you share what command you ran and what you expected to happen?

kefahi commented 11 months ago

I think this was my bad. The storybook binary itself was missing, hence running npm run docs/start fails. storybook package that provides the storybook binary was not mentioned in the packages.json file. I made further tuning to make storybook7 work properly.

Can be found on this git branch.

The above branch is based on the Svelte4 fixes branch that was prepared earlier.

I'm good now with both Svelte4 and Storybook7 without any known issues (including passing CI checks).

bestguy commented 11 months ago

Fixed with #576 Thanks all!