search

bestguy / sveltestrap

Bootstrap 4 & 5 components for Svelte
https://sveltestrap.js.org
MIT License
1.3k stars 180 forks source link

fix: make package to work correctly with Vite #566

Closed benmccann closed 10 months ago

benmccann commented 11 months ago

Fixes https://github.com/bestguy/sveltestrap/issues/562 Fixes https://github.com/bestguy/sveltestrap/issues/469

I'm afraid I missed a couple places this update was required in https://github.com/bestguy/sveltestrap/pull/356. Perhaps they were added in the two years since I authored the original PR and I didn't catch that there were new ones added. In any case, this seems to work in my testing

compwright commented 11 months ago

I'd love to see this get merged and released soon!

benmccann commented 11 months ago

@bestguy could we get a quick merge of this? I'm afraid my last PR is broken without it. Thanks!

benmccann commented 10 months ago

@bestguy @gary-mycase just a quick reminder about this PR. Thanks!

bestguy commented 10 months ago

Thanks, let me confirm this does not break svelte.dev REPL, this was the main issue before with this change.

pappasam commented 10 months ago

Curious... does this break svelte.dev, or is this lil PR good to go?

benmccann commented 10 months ago

Yes, this will work on the svelte.dev REPL. The last PR (https://github.com/bestguy/sveltestrap/pull/356) upgraded floating UI where I removed process.env so that it will work in a browser-based environment (https://github.com/floating-ui/floating-ui/pull/2296), so there should no longer be any issue.

bestguy commented 10 months ago

Awesome thanks guys, let me do a sanity check prerelease after work tonight, and if works will release new patch release for this

bestguy commented 10 months ago
Screenshot 2023-08-30 at 7 12 06 PM

Confirmed worked with Svelte REPL, and released as v5.11.2

Thanks all for the fixes, help, and patience with this! 💟

jonjes commented 10 months ago

Sweet! Thanks for this fix.