search

bestguy / sveltestrap

Bootstrap 4 & 5 components for Svelte
https://sveltestrap.js.org
MIT License
1.3k stars 180 forks source link

Svelte4 and Storybook7 fixes #575

Open kefahi opened 8 months ago

kefahi commented 8 months ago

This is more of a maintenance PR by which me and my colleague were able to update to Svelte4, Storybook7 and all deprecated packages.

Given that Svelte3 support is not maintained in this PR, and if it is accepted, we may consider making a major release ... e.g. 6.0 rc

benmccann commented 8 months ago

The formatting in this PR is all over the place. Mixes of double quotes and single quotes, unindented code, etc.

I think it'd be better to separate the Svelte 4 and Storybook 7 PRs to make them easier to review. This PR is 200 files, which is quite large

Also, what's the difference between your Svelte 4 changes and https://github.com/bestguy/sveltestrap/pull/574?