Have json3 behave as a shim in browsers even if loaded with require

[dmp42]

The problem I'm trying to solve is simple. I want json3 to behave uniformly as a shim in browsers (that is: patch/populate window.JSON if needed), independently of the way it is loaded.

Currently:

• if the browser doesn't have native JSON support, and json3.js is loaded in a script tag or with any other (non AMD) loader, that's ok (eg: window.JSON == JSON3)

But:

• if the browser doesn't have native JSON support, and json3.js is loaded with requirejs (or I assume any other AMD loader), it is exported only as a module, and doesn't populate window.JSON

Libraries that are willing to provide functionality relying on JSON (without explicitly requiring AMD) would then have to do their own guessing ("if amd then require json else window.JSON"), which is not good IMHO.

This patch tries to fix this shortcoming.

I hope this is cautious enough to not mess-up other (non-browser) environments, but admittedly I'm not familiar with them.

Thanks!

Regards,

• Olivier

[ghost]

Thanks very much for the patch! I've been terribly busy, but I will review it and take action later this weekend.

[dmp42]

There is no hurry of any sort :) Best.

[jeffrose]

Any progress on this issue?

[ghost]

Merged in f9c5e781d5b5592d04787defcba9e0646a291595. This will go out with the next release. Thanks!