search

bestiejs / json3

A JSON polyfill. No longer maintained.
https://bestiejs.github.io/json3
Other
1.02k stars 150 forks source link

publish 3.2.5a to npm #39

Closed jfirebaugh closed 11 years ago

jfirebaugh commented 11 years ago

The latest version on npm is broken on IE because it does't contain ae2cea69152f58dfc35402d1fae5087c72241e5d.

jfirebaugh commented 11 years ago

Also, in the future, please don't publish two different versions both labeled with the same version number in the source, as is the case with 3.2.5 and 3.2.5a. Just bump the patch version when you make a patch release. Helps keep the result of us developers sane.

ghost commented 11 years ago

@jfirebaugh Hmm, really? I ran npm install json3@3.2.5, and saw that it had the fix (just to confirm, I ran curl http://registry.npmjs.org/json3/-/json3-3.2.5.tgz | tar xvz and inspected json3/package/lib/json3.js). I can republish 3.2.5 again, or just push 3.2.6.

When I tagged 3.2.5, I realized that I hadn't merged ae2cea69152f58dfc35402d1fae5087c72241e5d or 23f9484f459a98b297483787a3ca1b5992dfc362 into the release branch. This was before I saw your reminder to publish to npm, so I rectified that with an informal v3.2.5a commit, and republished at that point (what's on npm is actually v3.2.5a). Yesterday, I rebuilt the minified version and republished again.

I'm really sorry for making such a mess of this. In the future, I'll do exactly as you suggested.

jfirebaugh commented 11 years ago

Huh, looks like you're right, sorry for the false alarm. I had "json3": "~3.2.5" in my package.json and npm install was leaving me with the non 'a' version in node_modules. Perhaps it never properly updated from the git source I had before the 3.2.5 release. I thought I had double checked the sources from npm install -g and saw the same issue, but I did it again just now and see v3.2.5a.

ghost commented 11 years ago

No worries. Thanks for keeping me honest.