search

bestiejs / json3

A JSON polyfill. No longer maintained.
https://bestiejs.github.io/json3
Other
1.02k stars 150 forks source link

Remove Prototype <= 1.6.1 Support #66

Closed bnjmnt4n closed 9 years ago

bnjmnt4n commented 10 years ago

Prototype <= 1.6.1 support was added quite some time ago, in #8, back when many people were still using outdated versions of Prototype. However, the current Prototype version is 1.7.2 (released this year), and the toJSON bug was fixed in 1.7 (released in 2010).

However, if we intend to use a replacer function to serialise Dates (as in #65), it might be difficult to ensure that the toJSON property of Strings, Numbers, Arrays and Dates are not called. Thus, I would recommend we remove support for Prototype <= 1.6.1.

@kitcambridge what do you think?

bnjmnt4n commented 10 years ago

Ping @kitcambridge :)

ghost commented 10 years ago

Sorry I missed this, @d10; thanks for the ping! Dropping support sounds like a great approach. We'll need a major version bump for #65 either way, and I think it's worthwhile sacrificing a legacy version of Prototype (particularly since many of its extensions now conflict with DOM 4 and ES 6) if it means we can fall back to Firefox's native implementation.

:+1:

bnjmnt4n commented 9 years ago

@kitcambridge what do you mean by a major version bump? v3.4.0?

ghost commented 9 years ago

v4.0. Granted, it's going to be interesting installing json3@4.0.0 from Bower or npm, but I think that ship has sailed.

bnjmnt4n commented 9 years ago

Note: we need to modify README.md when we release 4.0.

ghost commented 9 years ago

Also (noting for posterity)...folks who still need old Prototype support can keep using 3.x. If we find bugs affecting both 3.x and 4.x, we can always backport fixes; there's no mandate to upgrade.