search

bestiejs / json3

A JSON polyfill. No longer maintained.
https://bestiejs.github.io/json3
Other
1.02k stars 150 forks source link

Use `devDependencies` instead of `vendor` #67

Closed bnjmnt4n closed 5 years ago

bnjmnt4n commented 9 years ago

@jdalton recently did this for the other @bestiejs projects, so I was wondering if this could be done for JSON3 as well. Also, this would help to reduce the size of downloads from GitHub, as well as git.

bnjmnt4n commented 9 years ago

Ping @kitcambridge ;)

ghost commented 9 years ago

Let's do it. I think the only ones not on npm are evalJSON, json_parse, json_parse_state, and json_sans_eval.

bnjmnt4n commented 9 years ago

Yep, will do it sometime this week.

bnjmnt4n commented 9 years ago

Since we now use npm to install dependencies, and they are no longer included in our repository, the test and benchmark pages on our site won’t work. A possible solution is to shift our main branch to master and create a separate gh-pages branch where node_modules are included. This could be a task in our build.js file, where generated files are output to a dist folder. A script can then be used to update the generated files via Travis.

ghost commented 9 years ago

I think that's a fine idea—I can't remember why I made gh-pages the default. Let's use master as our default; that'll remove the need for dev, too.

bnjmnt4n commented 9 years ago

Note: if we make master the default and gh-pages just contains the built site, we would have to remove the Travis CI build status, as gh-pages wouldn't have tests anymore, while master contains the latest dev changes and thus could have a failing status, which would be shown on the site.