search

bestiejs / platform.js

A platform detection library.
https://mths.be/platform
MIT License
3.22k stars 408 forks source link

Add support for more Samsung devices. #155

Open BdR76 opened 6 years ago

BdR76 commented 6 years ago

Add support for detecting Samsung Galaxy S8, S9, A-series, J-series

BdR76 commented 6 years ago

Add more A5 and A7 models

Ethorsen commented 1 year ago

@BdR76 Any chances your modifs are published somewhere? I'd like to keep using platformjs for a bit but I just got a specific ticket about those galaxy devices

BdR76 commented 1 year ago

Doesn't look like the full change to platform.js is available because this pull request was reverted with another commit. I think it has to do with this other commit, which was a more robust away to detect Android devices. This old commit only added specific detection for up to the S9 models, because iirc that was the newest at that time.

You could reconstruct it using this commit and the current version of the platform.js maybe? But then you'd probably also have to add the S20, S21, S22 etc.