search

bestiejs / platform.js

A platform detection library.
https://mths.be/platform
MIT License
3.22k stars 408 forks source link

Platform1.3.5 : Microsoft Edge version is incorrect. #162

Closed JDGHHou closed 5 years ago

JDGHHou commented 5 years ago

I am using MS Edge 41.16299.551.0, but platform reports it as 16.16299. It looks like maybe it's grabbing the first two digits of the minor version rather than reporting the proper major version?

jdalton commented 5 years ago

Hi @JDGHHou!

You're looking at the app shell version and not the platform version. The platform version (the lower one) is the one to pay attention to.

JDGHHou commented 5 years ago

Can you please tell me a little more about that? If I am trying to make sure users have the latest browser, you are telling me that for Chrome I need to trust that Platform indicates the browser, while for Microsoft Edge, I am supposed to consider the "Microsoft EdgeHTML" version instead?

It's confusing because Platform.js reports the name of the app shell as platform.name for Microsoft Edge, instead of "Microsoft EdgeHTML," while for Chrome, it is reporting exactly what I see as the name of the browser. Should the platform code be updated to show "Microsoft EdgeHTML" instead?

When I go into Chrome and look in its settings, I see: Version 70.0.3538.102 (Official Build) (64-bit)

Then, when I open my web app with platform.js and call platform.toString(), I get: "Chrome 70.0.3538.102 on Windows 10 64-bit"

THEN...when I go into Microsoft Edge and look in its settings, I see: Microsoft Edge 41.16299.551.0 MicrosoftEdgeHTML 16.16299 (^ I see now where it's deriving the version number)

Then, when I open my web app with platform.js and call platform.toString(), I get: "Microsoft Edge v16.16299 on Windows 10 64-bit"