bestit / flagception-bundle

Feature flags on steroids!
MIT License
210 stars 42 forks source link

fixed susbcriber for invokable controllers #74

Closed vitsadecky closed 4 years ago

vitsadecky commented 4 years ago

fixed for invokable controller and shorten routing definition: symfony-invokable controllers

dont work before this MR: customer_promotional_voucher_list: path: /promotional-vouchers controller: App\Controller\Customer\Voucher\PromotionalVoucherListControlle

work only path: /promotional-vouchers controller: App\Controller\Customer\Voucher\PromotionalVoucherListController::__invoke

vitsadecky commented 4 years ago

@migo315 It same fix, like here Can you create hotfix 3.5.1 from this change too, please ?

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 188


Files with Coverage Reduction New Missed Lines %
src/Listener/AnnotationSubscriber.php 1 76.92%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 167: -0.2%
Covered Lines: 476
Relevant Lines: 477

💛 - Coveralls
coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 187


Files with Coverage Reduction New Missed Lines %
src/Listener/AnnotationSubscriber.php 1 76.92%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 167: -0.2%
Covered Lines: 476
Relevant Lines: 477

💛 - Coveralls
migo315 commented 4 years ago

Thanks for your pull requests. It's released under 4.0.1 and 3.5.1. ;-)

vitsadecky commented 4 years ago

@migo315 thank you very much!