bestit / flagception-bundle

Feature flags on steroids!
MIT License
210 stars 42 forks source link

Symfony 6.0 support #90

Closed amacrobert-meq closed 2 years ago

amacrobert-meq commented 2 years ago

Flagception does not list compatibility with Symfony 6.0.

I'm not seeing any deprecation messages when running flagception-bundle 4.1 on Symfony 5.4, so it probably doesn't need any code changes -- just a composer tweak.

This is the error I get when trying to update to Symfony 6.0 in a project that uses flagception-bundle:

$ composer update
Loading composer repositories with package information
Restricting packages listed in "symfony/symfony" to "6.0.*"
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Root composer.json requires flagception/flagception-bundle ^4.1 -> satisfiable by flagception/flagception-bundle[4.1.0].
    - flagception/flagception-bundle 4.1.0 requires symfony/dependency-injection ^4.4 | ^5.0 -> found symfony/dependency-injection[v4.4.0-BETA1, ..., v4.4.34, v5.0.0-BETA1, ..., v5.4.0] but these were not loaded, likely because it conflicts with another require.
mssimi commented 2 years ago

This bundle seems dead to me, is it?

migo315 commented 2 years ago

I'm so sorry. Since I changed to another company, I don't have access to this repository anymore.

@mKnoop @avareldev Can you check check and approve the open pr?

avareldev commented 2 years ago

Looking into it next year!

mssimi commented 2 years ago

@avareldev Is it rather beginning of the year or end? :)

gellis commented 2 years ago

@avareldev Any update on this?

mKnoop commented 2 years ago

Sorry for the late reply.

We will check the pr next week and try to schedule this for the next release.