SQL Editor area not filling available space.

bestlong / node-red-contrib-mssql-plus

A Node-RED node to read and write to Microsoft MS SQL Databases

MIT License

31 stars 18 forks source link

SQL Editor area not filling available space. #37

Closed damonroberts95 closed 3 years ago

damonroberts95 commented 3 years ago

I've recently updated from 0.3.2. to 0.5.0. and noticed the query editor portion of the node settings has shrunk significantly. This appears to be because the sidebar leaves space for the parameter 'editor' mode in 0.5.0, even when it isn't visible. It seems like the oneditresize function doesn't take into account whether the second editor is visible and leaves space for it regardless. This makes it hard to deal with more complex queries.

Below are screenshots of 0.5.0 and 0.3.2

Steve-Mcl commented 3 years ago

Hi @damonroberts95 , thanks for taking the time to raise an issue.

I will see if I can make the re-sizing of elements smarter next time i am in the code.

Cheers.

Steve-Mcl commented 3 years ago

I have made some UI improvements in V0.5.1 (44f0dc3)

add "none" option to parameters
make query window resize to available space
add expand button to further increase query editing size

I'd appreciate it if you update from NPM (or via node-red pallete when it appears)

damonroberts95 commented 3 years ago

Spot on, works perfectly! Better service than if it was paid for!

Steve-Mcl commented 3 years ago

did you test the expand button (top right of query editor)? Is that working too? If so, please comment and close :+1:

damonroberts95 commented 3 years ago

I did, also working perfectly (Forgot to mention it as I don't think I've ever actually used it before!)

damonroberts95 commented 3 years ago

As of updating to 0.6.2 the parameters editor window no longer hides itself if set to none.

Steve-Mcl commented 3 years ago

Oh. Dang. Well spotted. Not sure how I have managed that. Will look into it asap. Thanks.

Ps, if you could check the browser Devtools (F12) and let me know if there are any errors occuring when you select between parameters and none parameters, that would be helpful. Thanks.

damonroberts95 commented 3 years ago

I'm only getting [Violation] Forced reflow while executing JavaScript took 69ms when opening the dropdown. Nothing the rest of the time.

Everything else seems to be working well!

Steve-Mcl commented 3 years ago

Ok cheers. I'll look into it soon. Sorry for the troubles.

Steve-Mcl commented 3 years ago

Should be fixed in v0.6.3