search

bestlong / node-red-contrib-mssql-plus

A Node-RED node to read and write to Microsoft MS SQL Databases
MIT License
31 stars 18 forks source link

node.queryOptType should be node.paramsOptType #49

Closed stephanlotter closed 3 years ago

stephanlotter commented 3 years ago

If found a bug in mssql.js at the following line:

https://github.com/bestlong/node-red-contrib-mssql-plus/blob/4c9d4c1ae4984a3c7da63774bf47479bc4ee63a2/src/mssql.js#L595

It should be node.paramsOptType in stead of node.queryOptType:

} else if(!node.paramsOptType || node.paramsOptType == "editor") {

The bug causes parameter values passed in msg to not work.

Steve-Mcl commented 3 years ago

Hi, thanks for the feedback.

I believe this has been corrected in the 0.7.0-beta.4 version which will be released as 0.7.0 very soon

I will leave this open for now. I would appreciate it if you could feedback if everything is ok once it has been updated?

thanks.

Steve-Mcl commented 3 years ago

Hi

V0.7.0 is now published. Would you be kind enough to update, test & let me know if things are working as expected please?

stephanlotter commented 3 years ago

Looks great! Thanks!

Steve-Mcl commented 3 years ago

Cheers @stephanlotter .

Can we close this issue now?