search

bestlong / node-red-contrib-mssql-plus

A Node-RED node to read and write to Microsoft MS SQL Databases
MIT License
31 stars 18 forks source link

Plans to support both Native driver and Tedious? #56

Open smiziara opened 2 years ago

smiziara commented 2 years ago

Hello,

Do you have any plans to provide support for both the Native V8 driver for MSSQL alongside with the current one (Tedious)?

Im interested in using the Native version, so if you are not currently work on this, can we fork and add this functionality, or would you consider a PR?

Thanks.

bestlong commented 2 years ago

https://www.npmjs.com/package/msnodesqlv8 This one ?

PR is welcome.

smiziara commented 2 years ago

Yes.

Great so i will start developing it and when i have a first version will send for your review.

Thanks.

On Thu, Aug 12, 2021, 05:52 Shao Yu-Lung (Allen) @.***> wrote:

https://www.npmjs.com/package/msnodesqlv8 This one ?

PR is welcome.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bestlong/node-red-contrib-mssql-plus/issues/56#issuecomment-897463016, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA6FTIDQRHW4LV374ZNO33TT4ODUBANCNFSM5CAH6XAA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

Steve-Mcl commented 2 years ago

@bestlong are we sure we want to do this? I believe msNodesqlV8 needs to build on a user's system (so requires a user to have build tools ore-installed so that bindings can be compiled) and it has prerequisites (e.g. ODBC)

@smiziara how would you propose to provide users a choice between tedious and msNodesqlV8?

smiziara commented 2 years ago

Probably as an optional package.

If it's found and configured to use, we can use it, otherwise keep using tedious.

On Thu, Aug 12, 2021, 18:53 Stephen McLaughlin @.***> wrote:

@bestlong https://github.com/bestlong are we sure we want to do this? I believe msNodesqlV8 needs to build on a user's system (so requires a user to have build tools ore-installed so that bindings can be compiled) and it has prerequisites (e.g. ODBC)

@smiziara https://github.com/smiziara how would you propose to provide users a choice between tedious and msNodesqlV8?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bestlong/node-red-contrib-mssql-plus/issues/56#issuecomment-897992439, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA6FTIC3EOR2L3CZ7U53WSDT4Q7FPANCNFSM5CAH6XAA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

Steve-Mcl commented 2 years ago

@smiziara that seems like a reasonable approach. I would have been worried if it were a direct dependency.

Look forward to PR

bestlong commented 2 years ago

@Steve-Mcl Wait until we see the PR to decide.