search

bestmomo / nice-artisan

This package is to add a web interface for Laravel 5 and earlier Artisan.
213 stars 23 forks source link

Renaming the app #19

Open Traqza opened 5 years ago

Traqza commented 5 years ago

When you rename the application, it will break the app if you use a naming convention that includes spaces or special characters. Recommend adding a validation to strip all non available char and remove spaces to prevent future users from breaking things.

I broke the test environment I had setup and haven't tried naming the application with single string name yet to see if there's still an issue, doubtful.

Traqza commented 5 years ago

I would also recommend adding statements on dangerous artisan commands that can have problems arise if the end user is not aware of the repercussions of their actions.

Traqza commented 5 years ago

Attempted to change the name of the application to a single text word and it took the application down. Even composer wont acknowledge artisan commands.

bestmomo commented 5 years ago

Hi I just tested the name application change with a simple text word in a fresh Laravel 5.7 and all is ok for me...

Traqza commented 5 years ago

Hmm, did you use a all lower case string, or a upper? Did you run any commands before/after? Mine was on a live server when I tested it.