search

bestofjs / javascript-risingstars

:stars: An overview of the JavaScript landscape in 2023: trends about frontend, Node.js, fullstack frameworks, build tools, testing, Vue.js, React, state management...
https://risingstars.js.org
1.02k stars 56 forks source link

Translate 2017 version to Bahasa Indonesia #24

Closed lobothijau closed 6 years ago

lobothijau commented 6 years ago

Is there anything I should finish before doing this PR?

michaelrambeau commented 6 years ago

Hello @lobothijau Thank you for the translations and sorry for the late reply. I'm adjusting the layout so that the language menu fits the mobile screens, I will let you know when it's ready.

michaelrambeau commented 6 years ago

Hello @lobothijau I merged the Indonesian version into the dev branch. Could you check the result here: https://risingstars-dev.netlify.com/ (it's a temporary URL for tests only)?

lobothijau commented 6 years ago

Hello @michaelrambeau Thank you for your help. I have checked the result and it looks perfect for me unless there are some mistakes I found (some typos and punctuation). Can I update them and create a new PR after this PR is merged or should I just revise this PR?

michaelrambeau commented 6 years ago

Hello @lobothijau, Could you make a new PR because I have already merged everything into the master branch? Thank you!

lobothijau commented 6 years ago

Sure, I will do a new PR for them. Thank you for your assistance.