search

bestofjs / javascript-risingstars

:stars: An overview of the JavaScript landscape in 2023: trends about frontend, Node.js, fullstack frameworks, build tools, testing, Vue.js, React, state management...
https://risingstars.js.org
1.02k stars 56 forks source link

[2018] Missing Images #34

Closed BBlackwo closed 5 years ago

BBlackwo commented 5 years ago

These are all the missing images I found. You can see it's showing the alt text on the ToC.

screen shot 2019-01-05 at 2 17 42 pm
michaelrambeau commented 5 years ago

That's strange, thank you for the screenshot.

It looks like a browser cache or security issue because the images you can't see are the ones that are hosted on https://bestofjs.org.

For example: https://bestofjs.org/logos/hyperapp.png for Hyperapp.

Could you try to open the site in a private browser window ("New private window" on Firefox) or ("New Incognito Window" or Chrome)? And can you try in an other browser?

In the past, I had similar issue with the application https://bestofjs.org/, sometimes the latest assets are not served correctly...

BBlackwo commented 5 years ago

I think it's some sort of load balancing / multiple servers issue. If I open https://bestofjs.org/logos/hyperapp.png in incognito mode several times (e.g. 5 times), sometimes it works (4 times), sometimes it doesn't (1 time).

Normal chrome browsing does this (so it's probably stuck on the server without the image):

screen shot 2019-01-05 at 5 59 27 pm

But sometimes in incognito it works some of the time:

screen shot 2019-01-05 at 5 59 06 pm
michaelrambeau commented 5 years ago

Maybe it has to do with the cache on some instances of the load balancing system, because I guess that if you try an older logo like this one:

https://bestofjs.org/logos/angular.svg

...it always works, in all browsers, right, can you try?

Angular logo has been uploaded 8 months ago, while the Hyperapp logo is more recent, that's the difference.

BBlackwo commented 5 years ago

Yeah I think you're right. That Angular logo works fine every time in all browsers and I tried 6-7 times in incognito.

michaelrambeau commented 5 years ago

OK thank you very much for all the tests.

In the past, the only way I found to solve the problem was to build Best of JS from an other branch, different from master... that's what I have just done. Doing this seems to somehow invalidate the cache at the CDN servers level used by Netlify (Netlify is the service used to host all my Best of JS apps).

Could you try again the failing test about the Hyperapp logo?

michaelrambeau commented 5 years ago

...actually it does not seem to work (or not yet) because I have the same problem as you: opening the Hyperapp logo URL in a new Private window does not return the image... I'm doing more more tests, sorry for all my requests!

BBlackwo commented 5 years ago

Hmm okay. Yeah you should be able to reproduce it the same way I was. Let me know if you need anything else. Cheers.

michaelrambeau commented 5 years ago

Hello Benjamin @BBlackwo , I think I've found the cause of the problem.

Some months ago, I enabled a feature called "Split Testing" on the Netlify application, users were redirected randomly to a feature branch (that is now old). I totally forgot about that, it's my bad.

image

Could you try again the tests we run yesterday?

Thank you again for your help!

BBlackwo commented 5 years ago

@michaelrambeau works fine now. Good find :+1:

No worries for the help. Glad I mentioned it to you cause you might not have found it as your browser was hitting the correct branch 😄