search

bestofjs / javascript-risingstars

:stars: An overview of the JavaScript landscape in 2023: trends about frontend, Node.js, fullstack frameworks, build tools, testing, Vue.js, React, state management...
https://risingstars.js.org
1.02k stars 56 forks source link

Greeting! I filled the Chinese version of the 2018 edition #35

Closed seognil closed 5 years ago

seognil commented 5 years ago

well… also upgrade gatsby dep version because I got a build failure with the old one so I cant do the text job if you don't want it you can ignore that as your wish :)

michaelrambeau commented 5 years ago

Hello @seognil

Thank you very much for your hard work!

I'm going to merge your branch into a specific branch called zh so that we can check the result on a separate URL.

I think the gatsby version was frozen on purpose (1.9.172) to be able able to run the app locally and on Netlify using NPM and Node.js 8.4 (we don't use Gatsby), I'm going to confirm in a few minutes, wait a little...

michaelrambeau commented 5 years ago

@seognil Just to confirm, I had to revert the changes you did to fix the build, you can see the result here:

http://zh--risingstars.netlify.com/2018/zh

This is a temporally URL to check the branch called zh.

It will be merged to master and deployed later, stay tuned!