bestofjs / javascript-risingstars

:stars: An overview of the JavaScript landscape in 2023: trends about frontend, Node.js, fullstack frameworks, build tools, testing, Vue.js, React, state management...
https://risingstars.js.org
1.02k stars 56 forks source link

Zh | update Chinese version (and some code...) #38

Closed seognil closed 5 years ago

seognil commented 5 years ago

!!! breaking change !!!(the latest commit)

michaelrambeau commented 5 years ago

Hello @seognil Thank you very much for your hard work. You should be mentioned as a the translator of the 2018 edition, you are perfectly right.

About your PR, the fact that you re-used a previous branch annoys me, it makes the diffdifficult to understand, even if I understand it's only the result of the merge process.

So I have just updated the dev branch, adding you as a team member, as you see here:

https://dev--risingstars.netlify.com/2018/zh/

image

If you don't mind, could you add the corrections you mention about the SSG part and the Yarn problem, creating a new branch from dev?

Thank you for your understanding, sorry for the inconvenience!

seognil commented 5 years ago

@michaelrambeau ok I'll check that later (not much experience for open source project working process, bear with me :)

BTW, a translation problem. I'm not sure that what's the mean of archival from TypeScript, from Microsoft took a big advantage over its archival Flow Does that mean TS is inspired by Flow or Flow is TS's predecessor?

michaelrambeau commented 5 years ago

@seognil it was a typo in the English version, sorry, I wanted to write "arch-rival", I wanted to say that "Flow is the biggest rival of TypeScript".

seognil commented 5 years ago

@michaelrambeau so found a bug LOL

michaelrambeau commented 5 years ago

@seognil Thank you for having found the bug! 😄

And sorry for having closed your PR, it would be great if you open an other one with the changes you did in the Chinese translations.

FYI I will try to solve the NPM package version problem before the next edition, upgrading Gatsby and getting rid of Sass, I think.