Images are squashed on mobile

bestofjs / javascript-risingstars

:stars: An overview of the JavaScript landscape in 2023: trends about frontend, Node.js, fullstack frameworks, build tools, testing, Vue.js, React, state management...

https://risingstars.js.org

1.01k stars 56 forks source link

Images are squashed on mobile #55

Closed BBlackwo closed 4 years ago

BBlackwo commented 4 years ago

Hi Michael,

I found the images are squashed viewing the weekly issue on my phone.

Maybe on mobile, you could remove the "homepage" link and make the title clickable instead (like you do in the email)? That would give more room for the image.

BBlackwo commented 4 years ago

Or even easier, just remove the image on mobile?

michaelrambeau commented 4 years ago

Thank you @BBlackwo I will fix as soon as possible!

Also, since the buttons "GitHub" and "Homepage" takes a lot of place I could move them below the description, on mobile, it's an other option.

michaelrambeau commented 4 years ago

Hello @BBlackwo ! Could you check again, I've adjusted the layout? By the way you created the issue on "Rising Stars" project (the annual round-up) but the issue was about the weekly newsletter, I guess: https://weekly.bestofjs.org/

Sharing screenshots

375 px

520 px

BBlackwo commented 4 years ago

Hi @michaelrambeau, It looks much better now. 🙂

Woops, yes I should have raised it on the bestofjs-weekly repo sorry.

I've done a PR to increase the left padding slightly https://github.com/bestofjs/bestofjs-weekly/pull/7.

BBlackwo commented 4 years ago

Closing this as it's fixed now.