bestofjs / javascript-risingstars

:stars: An overview of the JavaScript landscape in 2023: trends about frontend, Node.js, fullstack frameworks, build tools, testing, Vue.js, React, state management...
https://risingstars.js.org
1k stars 56 forks source link

korean translate 2021 #97

Closed rewrite0w0 closed 2 years ago

rewrite0w0 commented 2 years ago

Add korean translation javascript rising star 2021

modify files allLanguages.json settings.json

and sorry. I added korean infomation at will because I thought it was first time for korean translate.

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/bestofjs/javascript-risingstars/45m4mC5oFdEDXrMxdDo16A8zhPPz
✅ Preview: https://javascript-risingstars-git-fork-rewrite0w0-kore-fc883e-bestofjs.vercel.app

rewrite0w0 commented 2 years ago

oh, I didn't notice. I deleted the file :)

michaelrambeau commented 2 years ago

@rewrite0w0 it seems you deleted the file package-lockfile this time 🗑️ 😄

You don't have to delete it: you have to discard the changes you made, so that the file does not appears in the list of "File changed" in this Pull Request, do you know what I mean, could you do it?

Thank you in advance!

rewrite0w0 commented 2 years ago

I deleted my file... then copied file from the original repo. I wonder if it'll be solved like this...? and thanks for advice :)

rewrite0w0 commented 2 years ago

I'm curious if there's any other way. git checkout --file, git fetch original repo I tried these two methods, but it didn't move I thought. sorry. if you fine, please can you teach me how to turn it back neatly...?

michaelrambeau commented 2 years ago

if you fine, please can you teach me how to turn it back neatly...?

@rewrite0w0 I think you can do that:

 git checkout origin/master package-lock.json

and then make a new commit.

rewrite0w0 commented 2 years ago

thanks for teach :) that was the right way. I didn't think about "git checkout from original" but i noticed that now.

michaelrambeau commented 2 years ago

@rewrite0w0 I'm adding your name, avatar and short bio at the bottom of the page.

What do you want to be displayed below your name, as your short bio? I can change your name on the screen if you prefer.

image

rewrite0w0 commented 2 years ago

name : Oh TaeJun bio: hello :)

please :)

michaelrambeau commented 2 years ago

name : Oh TaeJun bio: hello :)

Oh really, you don't want to be famous, you don't want to tell the world who you are? The world is watching! 🌐 😄

It would look like this:

image

OK like this?

rewrite0w0 commented 2 years ago

my thought was rewrite0w0(oh taejun) if you feeling so long... just rewrite0w0 please and my bio is hello :) please i love smile :)

michaelrambeau commented 2 years ago

No problem, anything is possible!

Like this?

image

rewrite0w0 commented 2 years ago

oh sorry, oh taejun (rewrite0w0) please Then I think it's completed. thanks :)

michaelrambeau commented 2 years ago

Is it OK to capitalize like this? (to be consisted with other language versions)

image

rewrite0w0 commented 2 years ago

If you capitalize j, it's perfect :D

michaelrambeau commented 2 years ago

Just to be 100%, like this? 😅

Oh TaeJun (rewrite0w0)
Hello :)
rewrite0w0 commented 2 years ago

yeah, perfect :)

michaelrambeau commented 2 years ago

@rewrite0w0 it's live, please check the result!

https://risingstars.js.org/2021/ko