Makefile has error

[GoogleCodeExporter]

In linux, with wrong Makefile, it fail to compile

deps/hiredis/Makefile

from line 10, it should be like this:

10 ifeq ($(uname_S),SunOS)
 11   CFLAGS?=-std=c99 -pedantic $(OPTIMIZATION) -fPIC -Wall -W -D__EXTENSIONS__ -D_XPG6 $(ARCH) $(PROF)
 12   CCLINK?=-ldl -lnsl -lsocket -lm -lpthread
 13   LDFLAGS?=-L. -Wl,-R,.
 14   DYLIBNAME?=libhiredis.so
 15   DYLIB_MAKE_CMD?=$(CC) -G -o ${DYLIBNAME} ${OBJ}
 16   STLIBNAME?=libhiredis.a
 17   STLIB_MAKE_CMD?=ar rcs ${STLIBNAME} ${OBJ}
 18 else
 19 ifeq ($(uname_S),Darwin)
 20   CFLAGS?=-std=c99 -pedantic $(OPTIMIZATION) -fPIC -Wall -W -Wwrite-strings $(ARCH) $(PROF)
 21   CCLINK?=-lm -pthread
 22   LDFLAGS?=-L. -Wl,-rpath,.
 23   OBJARCH?=-arch i386 -arch x86_64
 24   DYLIBNAME?=libhiredis.dylib
 25   DYLIB_MAKE_CMD?=libtool -dynamic -o ${DYLIBNAME} -lm ${DEBUG} - ${OBJ}
 26   STLIBNAME?=libhiredis.a
 27   STLIB_MAKE_CMD?=libtool -static -o ${STLIBNAME} - ${OBJ}
 28 else
 29   CFLAGS?=-std=c99 -pedantic $(OPTIMIZATION) -fPIC -Wall -W -Wwrite-strings $(ARCH) $(PROF)
 30   CCLINK?=-lm -pthread
 31   LDFLAGS?=-L. -Wl,-rpath,.
 32   DYLIBNAME?=libhiredis.so
 33   DYLIB_MAKE_CMD?=gcc -shared -Wl,-soname,${DYLIBNAME} -o ${DYLIBNAME} ${OBJ}
 34   STLIBNAME?=libhiredis.a
 35   STLIB_MAKE_CMD?=ar rcs ${STLIBNAME} ${OBJ}
 36 endif
 37 endif

Original issue reported on code.google.com by jipengch...@gmail.com on 21 Mar 2011 at 12:12

[GoogleCodeExporter]

Actually it works with 99% of Linux installs, but for some reason some Linux 
installs ship with a make version that is not able to recognize the form we 
use. I vote for switching to what you suggest.

Cheers,
Salvatore

Original comment by anti...@gmail.com on 21 Mar 2011 at 12:15

[GoogleCodeExporter]

Issue 549 has been merged into this issue.

Original comment by pcnoordh...@gmail.com on 14 Jun 2011 at 7:38

[GoogleCodeExporter]

Patch at: https://github.com/pietern/redis/commits/2.2-hiredis

Original comment by pcnoordh...@gmail.com on 14 Jun 2011 at 7:39

• Changed state: Started