search

besuper / TwitchNoSub

An extension to watch sub only VOD on Twitch
Apache License 2.0
1.64k stars 67 forks source link

No Bar to skip to specific time within VOD #17

Closed JeffJeffrey12 closed 2 years ago

JeffJeffrey12 commented 2 years ago

Not sure why, but I can't see the bar to skip to a later part in VOD properly - only arrow keys work.

besuper commented 2 years ago

Hi, can you send me a screenshot of your player

JeffJeffrey12 commented 2 years ago

I just saw that it appear in fullscreen, but not when not fullscreen. And I didn't find the option to show chat in options.

besuper commented 2 years ago

To enable the chat you need to click on the extension icon image then click on "Settings". You will see this: image

Rickkwa commented 2 years ago

So here we see the player controls are appearing correctly: image

But if I collapse the left sidebar, the player gets bigger but you can see the bottom of the stream is cut off, along with the player controls: image

ashishkotnala29 commented 2 years ago

Issue is caused by plyr. I do not know why the switch from videojs to plyr was made but I have reverted to videojs and this issue does not happen to me.

IMO plyr is outdated and not maintained anymore and hence videojs should be preferred. I also have observed memory leaks with plyr and some UI scaling issues which are not happening after going back to videojs.

I liked the support of playing "highlights" vod so I added support for those type of vod into previous code of v3 which is based on videojs so I'm not really missing anything.

besuper commented 2 years ago

Hey, the main reason to switch to plyr was to support firefox. It was easier for me to completely change the player instead of keeping videojs for firefox. But I switched back to videojs with partial support of firefox.

ashishkotnala29 commented 2 years ago

That's great @besuper thanks!