besuper / TwitchNoSub

An extension to watch sub only VOD on Twitch
Apache License 2.0
1.44k stars 62 forks source link

0.6.1 Not Working. Uncaught Type Error. #52

Open SabreRunner opened 1 year ago

SabreRunner commented 1 year ago

Uncaught TypeError: Cannot read properties of undefined (reading 'local')

Context

src/background.js

Stack Trace

src/background.js:6 (anonymous function)

`// Make background wake up chrome.webNavigation.onBeforeNavigate.addListener(function () {

}, { url: [{ hostContains: "twitch" }] });

var isChrome = chrome.declarativeNetRequest != undefined;

// Patching amazon service worker (75a2c99f45ecb5aa3225) if (isChrome) { // declarativeNetRequest only available on chrome chrome.declarativeNetRequest.updateDynamicRules({ addRules: [{ 'id': 1001, 'priority': 1, 'action': { 'type': 'redirect', 'redirect': { url: chrome.runtime.getURL("src/patched-amazon.js") } }, 'condition': { 'urlFilter': 'https://static.twitchcdn.net/assets/amazon-ivs-wasmworker.min-*.js', } }], removeRuleIds: [1001] }) } else { // Support firefox here browser.webRequest.onBeforeRequest.addListener( function (details) { return { redirectUrl: browser.runtime.getURL("src/patched-amazon.js") }; }, { urls: [ "https://static.twitchcdn.net/assets/amazon-ivs-wasmworker.min-*.js" ], types: ["main_frame", "script"] }, ["blocking"] ); }`

Google Chrome Chrome is up to date Version 108.0.5359.95 (Official Build) (64-bit)

besuper commented 1 year ago

Is the issue still there after reinstalling the extension?

reisei1 commented 1 year ago

0.6.2 also not working on Firefox. streams and clips won't play

Endymi0n74 commented 1 year ago

worked before, still working now on firefox 110.0a1 nightly without error

Rex000 commented 1 year ago

0.6.2 also not working on Firefox. streams and clips won't play

Yeah not working for me too unless I refresh, sometimes more than once. Seems it started after the recent firefox update.