besuper / TwitchNoSub

An extension to watch sub only VOD on Twitch
Apache License 2.0
1.64k stars 67 forks source link

What the heck is this heavily obfuscated javascript at the bottom of amazon-ivs-worker.min.js? #62

Closed BluBb-mADe closed 1 year ago

BluBb-mADe commented 1 year ago

At least for me, the unlock seems to work just fine without any of that so I am very dubious about what purpose this code serves.

besuper commented 1 year ago

Hi, https://github.com/besuper/TwitchNoSub/issues/57

BluBb-mADe commented 1 year ago

I have completely cleared all caches and history of chrome and the first page I ever visited was a locked VOD and it loaded just fine even after I removed that entire code block from the file and reinstalled the extension without it. It might be a good idea to confirm that it's not necessary (probably because twitch loads a wasm version of the player from a different file) and remove this dubious monstrosity if it's really not needed.

besuper commented 1 year ago

It's because the extension load the amazon worker from the github and not from the code itself. So i can keep the worker updated without updating the extension. You can check it in background.js